Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: redesign UI of the phishing warning page #176

Merged
merged 22 commits into from
Oct 17, 2024
Merged

Conversation

AugmentedMode
Copy link
Contributor

@AugmentedMode AugmentedMode commented Oct 8, 2024

This PR gives a fresh new look to MetaMask's phishing page with a bunch of UI/UX improvements. IMO this is a great v1 of the redesign, lets push this out there and then we can start v2 which will include better metric tracking on all clicks to help us better understand how to improve this page!

Key Improvements

  • New UI: Redesigned the UI to prioritize essential information and avoid overwhelming users with excessive text.

  • Added MetaMask Logo: Added the MetaMask logo on the phishing warning page to better tell users that MetaMask is the one safeguarding them from malicious websites. Even people at MetaMask thought this was googles warning page sometimes.

  • Green My Portfolio Button: Added a green My Portfolio button, allowing users to navigate safely to their portfolio. This will also direct more traffic to the portfolio page, with the warning screen being displayed ~400k times monthly. Shortly in the future this will redirect users to the security tab in the portfolio.

  • Twitter Share Button: Added a Twitter Share button enabling users to share their experience directly from the phishing warning page.

Current Phishing Page:

Screenshot 2024-10-08 at 2 58 42 PM

New Phishing Page

Screenshot 2024-10-16 at 11 43 28 AM

Twitter Share Button Functionality

Screenshot 2024-10-15 at 11 06 18 PM

@AugmentedMode AugmentedMode marked this pull request as draft October 16, 2024 03:01
@AugmentedMode AugmentedMode self-assigned this Oct 16, 2024
Copy link

socket-security bot commented Oct 16, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/design-tokens@4.0.0 None 0 227 kB metamaskbot
npm/caniuse-lite@1.0.30001668 None 0 2.11 MB ai, beneb, caniuse-lite

🚮 Removed packages: npm/@metamask/design-tokens@1.13.0, npm/caniuse-lite@1.0.30001561

View full report↗︎

@AugmentedMode AugmentedMode marked this pull request as ready for review October 16, 2024 04:53
mindofmar
mindofmar previously approved these changes Oct 16, 2024
Copy link

@mindofmar mindofmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mindofmar
mindofmar previously approved these changes Oct 16, 2024
mindofmar
mindofmar previously approved these changes Oct 16, 2024
Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great! To align with the MetaMask Design System and enhance the brand integrity and trust of this page, I suggest replacing the green on the button with the primary/default blue. I've created a draft PR with some UI updates here: #177

src/index.ts Outdated Show resolved Hide resolved
Copy link

@mindofmar mindofmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huge upgrade! LGTM

@AugmentedMode AugmentedMode merged commit 1bf3801 into main Oct 17, 2024
19 checks passed
@AugmentedMode AugmentedMode deleted the feat/redesign-ui branch October 17, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants